Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the actions enclosed in quotes are not updated #106

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix the actions enclosed in quotes are not updated #106

merged 2 commits into from
Sep 7, 2024

Conversation

kenz
Copy link
Contributor

@kenz kenz commented Jun 25, 2024 •
edited
Loading

Fixed regular expressions to support quoted action names.

Related Issues #94

Demo

Original action file

PullRequest created by Original version Github Actions Updater

Quoted actions are not updated.

+      - uses: actions/[email protected]
      - name: Without quotation
+        uses: actions/[email protected]

      - name: With single quotation
        uses: 'actions/[email protected]'

      - name: With double quotation
        uses: "actions/[email protected]"

https://github.com/kenz/github-action-updater-demo/pull/10/files

PullRequest created by supports quotation Version Github Actions Updater

Quoted actions also updated.

+      - uses: actions/[email protected]
      - name: Without quotation
+        uses: actions/[email protected]

      - name: With single quotation
+        uses: 'actions/[email protected]'

      - name: With double quotation
+        uses: "actions/[email protected]"

https://github.com/kenz/github-action-updater-demo/pull/11/files

@kenz kenz changed the title Actions enclosed in quotes are also included in the update target. Re… Fix the actions enclosed in quotes are not updated Jun 25, 2024
saadmk11
saadmk11 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Owner

@saadmk11 saadmk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. 🚀

@saadmk11 saadmk11 merged commit ef9573d into saadmk11:main Sep 7, 2024
2 checks passed
@saadmk11 saadmk11 mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadmk11 saadmk11 saadmk11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenz @saadmk11